[PATCH] D35495: [codeview] Fix YAML for LF_TYPESERVER2 by hoisting PDB_UniqueId

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 16:52:22 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/ObjectYAML/CodeViewYAMLTypes.cpp:163-166
+    uint8_t Value = (llvm::hexDigitValue(*Iter) << 4);
+    ++Iter;
+    Value |= llvm::hexDigitValue(*Iter);
+    ++Iter;
----------------
nit: you can use post-++ here


https://reviews.llvm.org/D35495





More information about the llvm-commits mailing list