[PATCH] D35504: [PDB] Merge in types and items from type servers (/Zi)

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/COFF/PDB.cpp:175-177
+  for (const CVType &Type : Types) {
+    if (Type.kind() != LF_TYPESERVER2)
+      break;
----------------
Is this possible that Types contain an LF_TYPESERVER2 and other types? If that is impossible, maybe this is more straightforward:

  if (Types.empty() || Types[0].kind() == LF_TYPESERVER2)
    return None;

  ...


https://reviews.llvm.org/D35504