[PATCH] D35495: [codeview] Fix YAML for LF_TYPESERVER2 by hoisting PDB_UniqueId

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 15:37:22 PDT 2017


ruiu added inline comments.


================
Comment at: lld/COFF/PDB.cpp:510
 
-  pdb::PDB_UniqueId uuid{};
+  WindowsGuid uuid{};
   if (DI)
----------------
Is WindowsGuid an appropriate name for this data strucutre? This is just a GUID and not really an Windows-variant.


https://reviews.llvm.org/D35495





More information about the llvm-commits mailing list