[PATCH] D29892: ar: add llvm-dlltool support

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lib/Object/COFFImportFile.cpp:167
+  // Create a weak external file which is described in PE/COFF Aux Format 3.
+  NewArchiveMember createWeakExternal(StringRef Sym, StringRef Weak, bool imp);
 };
----------------
LLVM coding style: imp -> Imp

(As I said, I really appreciate if you carefully review your patch yourself before sending it so that I don't need to point out all these style errors. It seems we are spending too much time on these kind of stuff and am honestly a bit tired of pointing them out.)


================
Comment at: lib/Object/COFFImportFile.cpp:483
+NewArchiveMember ObjectFactory::createWeakExternal(StringRef Sym,
+                                                   StringRef Weak, bool imp) {
+  static std::vector<uint8_t> Buffer;
----------------
imp -> Imp


================
Comment at: lib/Object/COFFImportFile.cpp:484-486
+  static std::vector<uint8_t> Buffer;
+  static const uint32_t NumberOfSections = 1;
+  static const uint32_t NumberOfSymbols = 5;
----------------
Why static?


Repository:
  rL LLVM

https://reviews.llvm.org/D29892