[PATCH] D35502: Add element-atomic mem intrinsic canary tests for InstCombine.

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/minor comment optional



================
Comment at: test/Transforms/InstCombine/element-atomic-memintrins.ll:10
+
+; Ensure 0-length memset isn't removed
+define void @test_memset_zero_length(i8* %dest) {
----------------
minor: I'd add "(yet)" to each of your comments.


================
Comment at: test/Transforms/InstCombine/element-atomic-memintrins.ll:20
+; Ensure that small-sized memsets don't convert to stores
+define void @test_memset_to_store(i8* %dest) {
+  ; CHECK-LABEL: test_memset_to_store
----------------
I mentioned to Daniel that instcombine also contains trivial DSE which should eventually trigger here, but given both cases are covered, I didn't ask for a separate test.


https://reviews.llvm.org/D35502