[PATCH] D35474: SSAUpdater: Add mode when Phi creation is not allowed
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 17 13:53:13 PDT 2017
efriedma added inline comments.
================
Comment at: include/llvm/Transforms/Utils/SSAUpdaterImpl.h:97
+ if (!FindAvailableVals(&BlockList))
+ return Traits::GetUndefVal(BB, Updater);
----------------
This is bad: the caller has no way to tell what happened if you return undef (is the value actually undef at the given point, or did PHI construction fail?).
https://reviews.llvm.org/D35474
More information about the llvm-commits
mailing list