[PATCH] D34963: [AArch64][Falkor] Avoid HW prefetcher tag collisions (step 1)

[Geoff Berry via Phabricator via llvm-commits]

gberry marked 3 inline comments as done.
gberry added inline comments.


================
Comment at: llvm/trunk/lib/Target/AArch64/AArch64FalkorHWPFFix.cpp:67-69
+    // FIXME: For some reason, preserving SE here breaks LSR (even if
+    // this pass changes nothing).
+    // AU.addPreserved<ScalarEvolutionWrapperPass>();
----------------
MatzeB wrote:
> how strange...
This was inherited from the LoopDataPrefetch pass.  I'll circle back and check if either of these are still necessary and if so if the underlying issue is fixable. 


================
Comment at: llvm/trunk/lib/Target/AArch64/AArch64FalkorHWPFFix.cpp:110
+  for (Loop *I : LI)
+    for (auto L = df_begin(I), LE = df_end(I); L != LE; ++L)
+      MadeChange |= runOnLoop(*L);
----------------
MatzeB wrote:
> no need for `auto`
It seems like most other code uses auto for df_iterators, so I've left this one alone.  I did rename 'I' to 'L' and 'L' to 'LIt' to hopefully make it a bit more clear.


Repository:
  rL LLVM

https://reviews.llvm.org/D34963