[PATCH] D35498: [LoopVectorizer] Use two step casting for float to pointer type.

Manoj Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 13:01:31 PDT 2017


manojgupta added a comment.

In https://reviews.llvm.org/D35498#811759, @rengolin wrote:

> Setting aside from the fact that no one should ever be casting floating point to pointers, perhaps we shouldn't be even trying to do this transformation here, as I'm not sure this could have a guaranteed semantics in this case, and probably better to just bail the vectorisation?
>
> Also, tests, etc. please.


I agree that  this transformation is unsafe and bailing out is the preferred way. Only if I knew where to add that check.


https://reviews.llvm.org/D35498





More information about the llvm-commits mailing list