[PATCH] D35495: [codeview] Fix YAML for LF_TYPESERVER2 by hoisting PDB_UniqueId

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
Herald added a subscriber: hiraditya.

We were treating the GUIDs in TypeServer2Record as strings, and the
non-ASCII bytes in the GUID would not round-trip through YAML.

We already had the PDB_UniqueId type portably represent a Windows GUID,
but we need to hoist that up to the DebugInfo/CodeView library so that
we can use it in the TypeServer2Record as well as in PDB parsing code.


https://reviews.llvm.org/D35495

Files:
  lld/COFF/PDB.cpp
  lld/test/COFF/pdb-type-server-missing.yaml
  llvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h
  llvm/include/llvm/DebugInfo/CodeView/Formatters.h
  llvm/include/llvm/DebugInfo/CodeView/TypeRecord.h
  llvm/include/llvm/DebugInfo/CodeView/WindowsGuid.h
  llvm/include/llvm/DebugInfo/PDB/DIA/DIARawSymbol.h
  llvm/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/Formatters.h
  llvm/include/llvm/DebugInfo/PDB/Native/InfoStream.h
  llvm/include/llvm/DebugInfo/PDB/Native/InfoStreamBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeExeSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeRawSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/RawTypes.h
  llvm/include/llvm/DebugInfo/PDB/PDBExtras.h
  llvm/include/llvm/ObjectYAML/CodeViewYAMLTypes.h
  llvm/lib/DebugInfo/CodeView/CodeViewRecordIO.cpp
  llvm/lib/DebugInfo/CodeView/Formatters.cpp
  llvm/lib/DebugInfo/CodeView/TypeDumpVisitor.cpp
  llvm/lib/DebugInfo/PDB/DIA/DIARawSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/InfoStream.cpp
  llvm/lib/DebugInfo/PDB/Native/InfoStreamBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeExeSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeRawSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/PDBTypeServerHandler.cpp
  llvm/lib/DebugInfo/PDB/PDBExtras.cpp
  llvm/lib/ObjectYAML/CodeViewYAMLTypes.cpp
  llvm/test/ObjectYAML/CodeView/guid.yaml
  llvm/tools/llvm-pdbutil/MinimalTypeDumper.cpp
  llvm/tools/llvm-pdbutil/PdbYaml.cpp
  llvm/tools/llvm-pdbutil/PdbYaml.h
  llvm/unittests/DebugInfo/PDB/TypeServerHandlerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35495.106905.patch
Type: text/x-patch
Size: 26682 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170717/39b017cc/attachment-0001.bin>