[PATCH] D35491: [opt-viewer] Accept directories that are searched for opt.yaml files
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 17 10:05:39 PDT 2017
davide added inline comments.
================
Comment at: tools/opt-viewer/optrecord.py:240-250
+def find_opt_files(dirs_or_files):
+ all = []
+ for dir_or_file in dirs_or_files:
+ if os.path.isfile(dir_or_file):
+ all.append(dir_or_file)
+ else:
+ for dir, subdirs, files in os.walk(dir_or_file):
----------------
anemet wrote:
> davide wrote:
> > this seems like something that can walk the whole filesystem if you end up passing the wrogn directory. Not sure there's a better way though.
> Do you mean like stuff mounted and so on?
Yes, exactly.
https://reviews.llvm.org/D35491
More information about the llvm-commits
mailing list