[PATCH] D35354: [X86][LLVM][TD] Arranging Atom family in an inheritance ratio

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86.td:419-420
   FeatureSlowIncDec,
   FeatureSlowBTMem,
-  FeatureSlowPMULLD,
-  FeatureLAHFSAHF
+  FeatureRDRAND
+]>;
----------------
m_zuckerman wrote:
> craig.topper wrote:
> > This looks to be adding RDRAND to SLM. Whether that's correct or not, that's a functional change which should not be part of this patch.
> hi. 
> First, this feature is part of SLM.
> Secondly , why don't you want it as part of the patch ? 
> 
I agree that it's part of SLM and that it should be fixed. But this patch should be treated as a refactor that doesn't change behavior. Especially since your description makes no mention of this change. And clang needs to be updated too. So submit a separate pre or post patch for the SLM rdrand change.


https://reviews.llvm.org/D35354