[PATCH] D35469: [AArch64] Make "Unkown Fixup" error msg more useful by giving Fixup Kind Name

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added a comment.

1. Is a functional change since it switches an assertion to an actual error report. It would be better to use "Ctx.reportError", and since I'm assuming you have places where this makes a difference to you, tests would be useful if possible. (If it was only useful in debugging an already fixed problem and you now can't trigger them we'd probably let it squeeze by, but the lack of tests should be called out and justified).
2. Trivial improvement, go ahead (you didn't need to post a patch for review for this kind of change). Shouldn't be part of the same commit as the others though.
3. Generally not encouraged since it messes up "git blame" history.


Repository:
  rL LLVM

https://reviews.llvm.org/D35469