[PATCH] D35433: AMDGPU: Fix amdgpu-flat-work-group-size/amdgpu-waves-per-eu check

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL308147: AMDGPU: Fix amdgpu-flat-work-group-size/amdgpu-waves-per-eu check (authored by kzhuravl).

Changed prior to commit:
  https://reviews.llvm.org/D35433?vs=106691&id=106817#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D35433

Files:
  llvm/trunk/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
  llvm/trunk/test/CodeGen/AMDGPU/attr-amdgpu-waves-per-eu.ll


Index: llvm/trunk/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
===================================================================
--- llvm/trunk/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
+++ llvm/trunk/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
@@ -277,7 +277,7 @@
   // Make sure requested values are compatible with values implied by requested
   // minimum/maximum flat work group sizes.
   if (RequestedFlatWorkGroupSize &&
-      Requested.first > MinImpliedByFlatWorkGroupSize)
+      Requested.first < MinImpliedByFlatWorkGroupSize)
     return Default;
 
   return Requested;
Index: llvm/trunk/test/CodeGen/AMDGPU/attr-amdgpu-waves-per-eu.ll
===================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/attr-amdgpu-waves-per-eu.ll
+++ llvm/trunk/test/CodeGen/AMDGPU/attr-amdgpu-waves-per-eu.ll
@@ -188,3 +188,15 @@
   ret void
 }
 attributes #9 = {"amdgpu-waves-per-eu"="10,10"}
+
+; Exactly 256 workitems and exactly 2 waves.
+; CHECK-LABEL: {{^}}empty_workitems_exactly_256_waves_exactly_2:
+; CHECK: SGPRBlocks: 12
+; CHECK: VGPRBlocks: 21
+; CHECK: NumSGPRsForWavesPerEU: 102
+; CHECK: NumVGPRsForWavesPerEU: 85
+define amdgpu_kernel void @empty_workitems_exactly_256_waves_exactly_2() #10 {
+entry:
+  ret void
+}
+attributes #10 = {"amdgpu-flat-work-group-size"="256,256" "amdgpu-waves-per-eu"="2,2"}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35433.106817.patch
Type: text/x-patch
Size: 1342 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170716/9b51f13b/attachment.bin>