[PATCH] D35458: [Polly][PM][WIP] Polly pass registration

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 16 08:47:03 PDT 2017


philip.pfaffe added a comment.

Hi Tobias,

I concur with your assessment regarding adding the passes via command line options. Will update the patch accordingly. Since none of the respective passes have been ported yet, that update might just be a TODO for the moment. Incremental progress and all :)

Some more thoughts regarding the appropriate extension points for Polly: The Early EP doesn't exist anymore. While I have an idea about getting something comparable back, we still should explore other options. I think the `CGSCCOptimizerLateEPCallback` could be worth consideration. It runs CGSCC passes right at the end of the module simplification pipeline. Another option could be ScalarLate. While that isn't exactly a full `O1` (because that is a subset of `O3`, but not a true prefix) it could be close enough. Most importantly, it does include an InlinerPass. To get a good idea about the O pipelines, check out https://github.com/llvm-mirror/llvm/blob/master/test/Other/new-pm-defaults.ll. This test shows the complete order of passes in the O pipelines, as well as the positions of the individual extension points.
LoopLate seems to be a bad idea to me, I'd probably just skip this for now, and add it should the need arise.


Repository:
  rL LLVM

https://reviews.llvm.org/D35458





More information about the llvm-commits mailing list