[PATCH] D34602: [GlobalISel][X86] Support call ABI.

[Igor Breger via Phabricator via llvm-commits]

igorb added inline comments.


================
Comment at: test/CodeGen/X86/GlobalISel/callingconv.ll:123
+
+declare void @trivial_callee()
+define void @test_trivial_call() {
----------------
oren_ben_simhon wrote:
> oren_ben_simhon wrote:
> > Could you please add tests that exercise arguments and return values that are spitted (like structures)?
> Where are the tests for returned/passed structures?
struct not supported yet. 
please see split_return_callee  test. In this case <8 x i32> split to 2 xmm registers.
Struct/array will have similar implementations.


https://reviews.llvm.org/D34602