[PATCH] D35132: [cmake] GetSVN.cmake takes a list of arguments

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 15 12:03:36 PDT 2017


modocache added a comment.

Friendly ping! I'm pretty excited about this set of changes, which simplify the CMake in projects such as Swift:

1. https://reviews.llvm.org/D35132: Convert "first", "second" parameters to a parameter that takes a list of items
2. https://reviews.llvm.org/D35133: Use the new parameters in Clang's CMake
3. https://reviews.llvm.org/D35138: Delete the old "first", "second" parameters

Does anyone have any feedback on these changes?


https://reviews.llvm.org/D35132





More information about the llvm-commits mailing list