[PATCH] D35422: Add MemoryMappedSection struct for two-level memory map iteration

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_procmaps.h:60
+
+ private:
+#if SANITIZER_MAC
----------------
fjricci wrote:
> alekseyshl wrote:
> > Move private under #if
> Unfortunately, the linter complains if you don't have a blank line before private. It looks a bit odd to me to have:
> 
> ```
> #if SANITIZER_MAC
> 
> private:
>   friend class MemoryMappingLayout;
> ```
> 
> What do you think?
It's fine with me, it's better than NOLINT comment or private: outside of the #if


https://reviews.llvm.org/D35422