[PATCH] D35437: Don't break bundles when adding DBG_VALUE

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:671
         for (auto &SP : Spills)
-          MBB->insertAfter(MachineBasicBlock::iterator(*SP.SpillInst),
-                           SP.DebugInst);
+          if( ! SP.SpillInst->isBundledWithSucc() ) // Don't break bundles.
+            MBB->insertAfter(MachineBasicBlock::iterator(*SP.SpillInst),
----------------
probinson wrote:
> Please add a FIXME to preserve these DBG_VALUEs.  I don't know how to do that, but losing them is not great.
I agree with Paul here. The DBG_VALUE instruction should be inserted after the bundle then.


https://reviews.llvm.org/D35437