[PATCH] D35334: ThinLTO Minimized Bitcode File Size Reduction

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: test/Transforms/ThinLTOBitcodeWriter/no-type-md.ll:40
 ; CHECK: !llvm.dbg.cu
 ; NODEBUG-NOT: !llvm.dbg.cu
+; NODEBUG-NOT: IDENTIFICATION_BLOCK_ID
----------------
haojiewang wrote:
> pcc wrote:
> > haojiewang wrote:
> > > pcc wrote:
> > > > This part of the test is no longer relevant.
> > > You mean that I'd better write a new test file, right? Along with the llvm-lto2 test.
> > I just mean that if you're now reading the file with llvm-bcanalyzer instead of llvm-dis you wouldn't expect the output to contain `!llvm.dbg.cu` either with or without your change, so it doesn't make sense to test for it. You can keep the rest of the test in this file.
> > 
> > Regarding llvm-lto2, you could either create a new test file or convert this one to use llvm-lto2 instead of llvm-lto.
> Current thin link bitcode cannot be read by llvm-lto2. I'm tracing the reason and trying to find how to fix it. Do we need fix this in this patch?
How are you calling llvm-lto2? You're passing `-thinlto-distributed-indexes`, right?


https://reviews.llvm.org/D35334