[PATCH] D35425: Implement parsing and writing of a single xml manifest file.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added inline comments.


================
Comment at: llvm/lib/Support/WindowsManifestMerger.cpp:46
+	#if defined(LIBXML2_ENABLED)
+	outs() << "LIBXML2_ENABLED\n";
+	if (CombinedRoot)
----------------
remove


================
Comment at: llvm/test/CMakeLists.txt:141
+if (LIBXML2_FOUND AND NOT LLVM_DISABLE_LIBXML2)
+  message (STATUS "enabling llvm-mt tests")
+  set(LLVM_TEST_DEPENDS ${LLVM_TEST_DEPENDS}
----------------
remove


================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:147
+  std::unique_ptr<MemoryBuffer> OutputBuffer = Merger.getMergedManifest();
+  outs() << "Buffer size " << OutputBuffer->getBufferSize() << "\n";
+  if (OutputBuffer->getBufferSize() == 0) {
----------------
remove


================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:153
+        FileOutputBuffer::create(OutputFile, OutputBuffer->getBufferSize());
+    outs() << "about to check file or err\n";
+    if (!FileOrErr)
----------------
remove


================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:156
+      reportError(OutputFile, FileOrErr.getError());
+    outs() << "created good\n";
+    std::unique_ptr<FileOutputBuffer> FileBuffer = std::move(*FileOrErr);
----------------
remove


https://reviews.llvm.org/D35425