[PATCH] D35333: Create empty shell of llvm-mt.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:48
+               HELPTEXT, METAVAR, VALUES)                                      \
+  {                                                                            \
+      PREFIX,      NAME,      HELPTEXT,                                        \
----------------
ruiu wrote:
> This open parenthesis is not at the same indentation depth as the closing one.
Is this done?


================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:66
+LLVM_ATTRIBUTE_NORETURN void reportError(Twine Msg) {
+  errs() << "llvm-mt error: " << Msg;
+  exit(1);
----------------
ruiu wrote:
> It is convenient to write out "\n" here, instead of embedding "\n" as part of Msg.
It's not done.


================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:71
+
+int main(int argc_, const char *argv_[]) {
+  sys::PrintStackTraceOnErrorSignal(argv_[0]);
----------------
ruiu wrote:
> Please follow the LLVM naming convention.
`argc` and `argv` still don't follow the LLVM naming convention.


https://reviews.llvm.org/D35333