[PATCH] D33880: COFF: Introduce LD shim around LINK

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/include/lld/Driver/Driver.h:21
+bool ldshim(llvm::ArrayRef<const char *> Args,
+          llvm::raw_ostream &Diag = llvm::errs());
 }
----------------
martell wrote:
> ruiu wrote:
> > Indentation. Please use clang-format-diff before sending patches so that human reviewers can focus on meaning of the code instead of formatting.
> I will use `git diff -U999 HEAD^ | clang-format-diff.py -i -p1` going forward. Thanks.
Can you upload a clang-formatted version? This indentation is still wrong.


================
Comment at: lld/lib/Shim/COFFLdShim.cpp:1
+//===- lib/Shim/COFFLdShim.cpp --------------------------------------------===//
+//
----------------
Move this file and other files in this directory to `lld/Mingw` (do not include `lib` or something, but just that directory).

Mingw is probably not the best name, but we already have COFF and ELF, and I can't think of any good name that briefly conveys the idea that this is "GNU-style ld command line frontend for Windows".


Repository:
  rL LLVM

https://reviews.llvm.org/D33880