[PATCH] D35209: [ARM] Unify handling of M-Class system registers

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added inline comments.


================
Comment at: lib/Target/ARM/ARMSystemRegister.td:26-29
+                   bits<1> NeedsSecExt,
+                   bits<1> NeedsDSP,
+                   bits<1> NeedsV8M,
+                   bits<1> NeedsV7M,
----------------
These seem to be duplicating the existing subtarget feature interface used by the assembler, which ought to be available (and used in the AArch64 sysreg definitions).

I could see using a single bit being neater for 1-2 such features, but it seems a little dubious for 4 of them. So is there any particular reason you dropped the "Requires" interface?


https://reviews.llvm.org/D35209