[PATCH] D35398: Add filename support to yaml::Input.
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 14 04:58:27 PDT 2017
asb added a comment.
This isn't part of LLVM I usually hack on, but I just wanted to comment to say:
1. I've manually verified this patch applies cleanly to top of tree and all checks pass
2. The patch looks good to me, and addresses the final nits from @arphaman in the previous revision. The only other changes vs the previous revision seems to be the removal of CurrentNode from the initialiser list as the field now has a default initialiser (as of https://reviews.llvm.org/rL305969).
@arphaman: are you happy with this patch now?
https://reviews.llvm.org/D35398
More information about the llvm-commits
mailing list