[PATCH] D35408: [mips] Fix floating point select machine verifier errors

Stefan Maksimovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 03:54:34 PDT 2017


smaksimovic created this revision.
Herald added a subscriber: arichardson.

Introduced FSELECT node necesary when lowering ISD::SELECT which
has i32, f64, f64 as its operands.
SEL_D instruction required that its output and first operand of
SELECT node, which it used, have matching types.
MTC1_D64 node introduced to aid FSELECT lowering.

This fixes machine verifier errors on following files:
`CodeGen/Mips/llvm-ir/select-dbl.ll`
`CodeGen/Mips/llvm-ir/select-flt.ll`
`CodeGen/Mips/select.ll`


https://reviews.llvm.org/D35408

Files:
  lib/Target/Mips/MicroMips32r6InstrInfo.td
  lib/Target/Mips/Mips32r6InstrInfo.td
  lib/Target/Mips/MipsCondMov.td
  lib/Target/Mips/MipsISelLowering.cpp
  lib/Target/Mips/MipsISelLowering.h
  lib/Target/Mips/MipsInstrFPU.td
  lib/Target/Mips/MipsSEISelLowering.cpp
  lib/Target/Mips/MipsSEISelLowering.h
  test/CodeGen/Mips/llvm-ir/select-dbl.ll
  test/CodeGen/Mips/llvm-ir/select-flt.ll
  test/CodeGen/Mips/select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35408.106607.patch
Type: text/x-patch
Size: 17932 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170714/9a723444/attachment.bin>


More information about the llvm-commits mailing list