[PATCH] D34661: [X86][MMX] Added custom lowering action for MMX SELECT (PR30418)
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 14 01:49:36 PDT 2017
RKSimon added inline comments.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:427
+
+ continue;
setOperationAction(ISD::SELECT, VT, Custom);
----------------
This diff is still broken - I'm assuming it should be before this for loop and after the loop with the other SELECT/SETCC declarations?
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:30573
+ DAG.getNode(ISD::SELECT, DL, MVT::i64, Cond, LHS, RHS);
+ return DAG.getBitcast(VT, newSelect);
----------------
Again, the diff is broken - its embedded in the middle of combineCMov's constant folding code.....
https://reviews.llvm.org/D34661
More information about the llvm-commits
mailing list