[PATCH] D35315: [Dominators] Make IsPostDominator a template parameter
Tobias Grosser via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 13 23:38:44 PDT 2017
grosser added a comment.
In https://reviews.llvm.org/D35315#808273, @kuhar wrote:
> In https://reviews.llvm.org/D35315#808241, @dberlin wrote:
>
> > For the cases that are always true, can you just use PostDominatorTree instead?
>
>
> From what I understand, PostDominatorTree lives in lib/Analysis and I'm not sure if I can include it everywhere.
>
> How about we add something like:
>
> template <typename T> using ForwardDomTreeBase = DominatorTreeBase<T, false>;
> template <typename T> using PostDomTreeBase = DominatorTreeBase<T, true>;
>
>
> at the bottom of `GenericDominatorTree.h` and use it instead of `DominatorTreeBase<T, true/false>`?
I like this suggestion!
https://reviews.llvm.org/D35315
More information about the llvm-commits
mailing list