[PATCH] D34555: [NVPTX] Add lowering of i128 params.

[Denys Zariaiev via llvm-commits]

Could you please land it? I don't have write access.

On Thu, Jul 13, 2017 at 8:09 PM Hal Finkel <hfinkel at anl.gov> wrote:

>
> On 07/13/2017 01:05 PM, Denys Zariaiev via Phabricator via llvm-commits
> wrote:
> > denzp added a comment.
> >
> > In https://reviews.llvm.org/D34555#802254, @tra wrote:
> >
> >> In https://reviews.llvm.org/D34555#802008, @denzp wrote:
> >>
> >>> Is it safe just to change data layout at clang side? Won't it break
> backward compatibility?
> >>
> >> Clang and LLVM sides of this change should land together as they have
> to be in sync.
> >>
> >> Other than that, AFAICT it should be safe as it affects only i128 which
> is not currently supported, so there should be no backward compatibility
> issues. That's in theory. You may want to ask this question on cfe-dev at .
> >
> > Looks like we can simply update Clang's data layout and it should not
> break anything: cfe-dev thread <
> http://lists.llvm.org/pipermail/cfe-dev/2017-July/054649.html>.
> >
> > Do I need to create a "differential" for the clang patch? I attached the
> diff to my previous comment here, and changes there are quite trivial.
>
> No, just go ahead and recommit along with the Clang change.
>
>   -Hal
>
> >
> >
> > Repository:
> >    rL LLVM
> >
> > https://reviews.llvm.org/D34555
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> --
> Hal Finkel
> Lead, Compiler Technology and Programming Languages
> Leadership Computing Facility
> Argonne National Laboratory
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170713/20aa5f73/attachment.html>