[PATCH] D33964: [LLVM][llvm-objcopy] Added basic plumbing to get things started

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich updated this revision to Diff 106571.
jakehehrlich added a comment.

1. Changed firstSection to use !empty() instead of implicitly converting size() to a bool
2. Segments should now keep track of empty sections. I don't think this would have caused an issue but I agree that it is a problem none the less. It shouldn't ever affect layout but it could affect other analysis.
3. Added a helper "is covered by" method to clean things up as recommended by James
4. Fixed a spelling mistake pointed out by James


Repository:
  rL LLVM

https://reviews.llvm.org/D33964

Files:
  test/tools/llvm-objcopy/basic-copy.test
  test/tools/llvm-objcopy/empty-section.s
  test/tools/llvm-objcopy/hello-world.s
  tools/LLVMBuild.txt
  tools/llvm-objcopy/CMakeLists.txt
  tools/llvm-objcopy/LLVMBuild.txt
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h
  tools/llvm-objcopy/llvm-objcopy.cpp
  tools/llvm-objcopy/llvm-objcopy.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33964.106571.patch
Type: text/x-patch
Size: 25602 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170714/3f526674/attachment.bin>