[PATCH] D35395: ELF: Reword a somewhat misleading error message.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 17:23:24 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL307983: ELF: Reword a somewhat misleading error message. (authored by pcc).

Changed prior to commit:
  https://reviews.llvm.org/D35395?vs=106563&id=106567#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D35395

Files:
  lld/trunk/ELF/Symbols.cpp
  lld/trunk/test/ELF/invalid/tls-symbol.s


Index: lld/trunk/ELF/Symbols.cpp
===================================================================
--- lld/trunk/ELF/Symbols.cpp
+++ lld/trunk/ELF/Symbols.cpp
@@ -94,7 +94,7 @@
     if (D.isTls() && !Config->Relocatable) {
       if (!Out::TlsPhdr)
         fatal(toString(D.File) +
-              " has a STT_TLS symbol but doesn't have a PT_TLS section");
+              " has an STT_TLS symbol but doesn't have an SHF_TLS section");
       return VA - Out::TlsPhdr->p_vaddr;
     }
     return VA;
Index: lld/trunk/test/ELF/invalid/tls-symbol.s
===================================================================
--- lld/trunk/test/ELF/invalid/tls-symbol.s
+++ lld/trunk/test/ELF/invalid/tls-symbol.s
@@ -1,5 +1,5 @@
 # REQUIRES: x86
 
-## The test file contains a STT_TLS symbol but has no TLS section.
+## The test file contains an STT_TLS symbol but has no TLS section.
 # RUN: not ld.lld %S/Inputs/tls-symbol.elf -o %t 2>&1 | FileCheck %s
-# CHECK: has a STT_TLS symbol but doesn't have a PT_TLS section
+# CHECK: has an STT_TLS symbol but doesn't have an SHF_TLS section


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35395.106567.patch
Type: text/x-patch
Size: 1081 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170714/c5deae54/attachment.bin>


More information about the llvm-commits mailing list