[PATCH] D35392: [PDB] Put LLD's PDB writing code in a class NFC

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 17:09:42 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/PDB.cpp:545-546
+  NativePath = Config->PDBPath;
+  llvm::sys::fs::make_absolute(NativePath);
+  llvm::sys::path::native(NativePath, llvm::sys::path::Style::windows);
+  uint32_t PdbFilePathNI = DbiBuilder.addECName(NativePath);
----------------
You can remove `llvm::`.


https://reviews.llvm.org/D35392





More information about the llvm-commits mailing list