[PATCH] D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess.

[David Kreitzer via Phabricator via llvm-commits]

DavidKreitzer added a comment.

Hi Michael, I have one small additional comment. Otherwise, this looks good.



================
Comment at: lib/Target/X86/X86ISelLowering.h:1457
+  /// succeed.
+  template <typename T>
+  void scaleShuffleMask(int Scale, ArrayRef<T> Mask,
----------------
Did you want to have T default to int as you did for createUnpackShuffleMask? That will avoid the extra changes in X86ISelLowering.cpp.



https://reviews.llvm.org/D34601