[PATCH] D35229: [CodeGen] Add support for instruction clusters

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 14:24:56 PDT 2017


evandro added inline comments.


================
Comment at: llvm/lib/CodeGen/ScheduleDAGInstrs.cpp:242
+              UseSU->print(dbgs()); dbgs() << '\n';);
+        UseSU->addPred(SDep(SU, SDep::Artificial));
+      }
----------------
javed.absar wrote:
> May be I am bit confused here, but should it not be SDep(Def, SDep::Artificial) ? 
> Please consider rewording the comment to make the intention clearer, if possible. 
For each instruction, go over its predecessors looking for any instruction that's clustered to it.  Then, go over the successors of the clustered instruction and bind them to the original instruction.


Repository:
  rL LLVM

https://reviews.llvm.org/D35229





More information about the llvm-commits mailing list