[PATCH] D35358: [scudo] Do not grab a cache for secondary allocation & per related changes

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 13:28:10 PDT 2017


cryptoad updated this revision to Diff 106510.
cryptoad marked 10 inline comments as done.
cryptoad added a comment.

Addressing Aleksey's comments:

- introduce allocate{Primary,Secondary} and their deallocation counterparts in the combined allocator. As explained in the comments, the Secondary functions do not require a Cache parameter, and the Primary allocation function doesn't require an Alignment parameter. That simplifies the prototypes;
- bring back `AllocSize`, add `/*xxx=*/` for "inlined" parameters (which now is really only one instance of `getActuallyAllocatedSize`);

One additional change:

- the Combined functions were not compliant with the LLVM coding style, make them start with a lower case character. They were already "verb actions".


https://reviews.llvm.org/D35358

Files:
  lib/scudo/scudo_allocator.cpp
  lib/scudo/scudo_allocator_combined.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35358.106510.patch
Type: text/x-patch
Size: 11100 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170713/de217497/attachment.bin>


More information about the llvm-commits mailing list