[PATCH] D35339: Delay removal of pubtypes and pubnames

[Rafael Avila de Espindola via llvm-commits]

George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> grimar added a comment.
>
> This looks fine for me as is too, but have few ideas to share.
>
>
>
> ================
> Comment at: ELF/InputFiles.cpp:511
> -      (Name == ".debug_gnu_pubnames" || Name == ".debug_gnu_pubtypes"))
> -    return &InputSection::Discarded;
> -
> ----------------
> What about leaving it here (for consistency with others discarded sections), but marking as dead from start ?
>
> ```
>   if (Config->GdbIndex &&
>       (Name == ".debug_gnu_pubnames" || Name == ".debug_gnu_pubtypes")) {
>    InputSectionBase *Sec = make<InputSection>(this, &Sec, Name);
>    Script->discard({Sec});
>    return Sec;
> }
> ```

This is awesome. It makes this patch so simple I think I will just fold
it with the final change.

Thanks,
Rafael