[PATCH] D35319: LSE Atomics reorg - Part I

Stefan Teleman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 08:44:22 PDT 2017


steleman added inline comments.


================
Comment at: lib/Target/AArch64/AArch64DeadRegisterDefinitionsPass.cpp:124
+      CASE_AARCH64_ATOMIC_(CASA):
+      CASE_AARCH64_ATOMIC_(CASAL):
+
----------------
t.p.northover wrote:
> christof wrote:
> > I don't think CAS and CASP lose acquire semantics when they target the zero register. Am I wrong?
> I think christof is right too. LD* and SWP are the ones affected.
Yes, after re-reading the Errata three times, CAS/CASP shouldn't be excluded.



Repository:
  rL LLVM

https://reviews.llvm.org/D35319





More information about the llvm-commits mailing list