[PATCH] D35006: [AArch64] Implement support for windows style vararg functions

[Tim Northover via Phabricator via llvm-commits]

t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.

Thanks for updating the patch. Looks really good to me, just one trivial comment about a comment.



================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:2833-2834
       // save them for future reference.
+      // For Win64 variadic functions, all float arguments are passed in integer
+      // registers.
       saveVarArgRegisters(CCInfo, DAG, DL, Chain);
----------------
Minor nit (just change and commit), but that's peripheral to why Win64 needs registers to be saved. The key point is something along the lines of "Win64 also passes variadic arguments  in registers".


https://reviews.llvm.org/D35006