[PATCH] D34661: [X86][MMX] Added custom lowering action for MMX SELECT (PR30418)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 04:26:24 PDT 2017


RKSimon added a comment.

This diff looks like it has gone bad being rebased?



================
Comment at: test/CodeGen/X86/select-mmx.ll:2
+; RUN: llc -mcpu=x86_64 -march=x86_64 -mattr=+mmx < %s | FileCheck %s --check-prefix=X64
+; RUN: llc -mcpu=pentium4 -march=x86 -mattr=+mmx < %s | FileCheck %s --check-prefix=I32
+
----------------
Use triples + attributes instead of arch/cpu (avoids test failure on different machines):
```
; RUN: llc -mtriple=x86_64-unknown-unknown -mattr=+mmx < %s | FileCheck %s --check-prefix=X64
; RUN: llc -mtriple=i686-unknown-unknown -mattr=+mmx < %s | FileCheck %s --check-prefix=I32
```


https://reviews.llvm.org/D34661





More information about the llvm-commits mailing list