[PATCH] D35310: [PM] Use range-based for loops in LegacyPassManager.cpp (NFC).
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 13 02:36:38 PDT 2017
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with one minor request.
================
Comment at: lib/IR/LegacyPassManager.cpp:1073
- for (AnalysisUsage::VectorType::const_iterator
- I = AnUsage->getRequiredSet().begin(),
- E = AnUsage->getRequiredSet().end(); I != E; ++I) {
- Pass *Impl = findAnalysisPass(*I, true);
+ for (const AnalysisID I : AnUsage->getRequiredSet()) {
+ Pass *Impl = findAnalysisPass(I, true);
----------------
Could you use ID here instead of I, please, for consistency (and readability)?
https://reviews.llvm.org/D35310
More information about the llvm-commits
mailing list