[PATCH] D35248: [ARM] Tidy up and organise better ARM.td. NFC.

[Diana Picus via Phabricator via llvm-commits]

rovka accepted this revision.
rovka added a comment.

I don't see anything wrong with this.
I'm not a huge fan of splitting string literals, since it makes it harder to grep for things, but I see there was already some precedent for that in the file and I assume this is what clang-format does too, so it's fine.



================
Comment at: lib/Target/ARM/ARM.td:23
 
-class ProcNoItin<string Name, list<SubtargetFeature> Features>
- : Processor<Name, NoItineraries, Features>;
-
-class Architecture<string fname, string aname, list<SubtargetFeature> features >
+class Architecture<string fname, string aname, list<SubtargetFeature> features>
   : SubtargetFeature<fname, "ARMArch", aname,
----------------
Nitpick: maybe move this down to line 469-ish, where the architectures are defined? At a superficial glance it doesn't seem to be needed before that.


https://reviews.llvm.org/D35248