[PATCH] D35292: [SLPVectorizer] Add propagateIRFlagsWithOp() function to propagate IRFlags for specific Operation

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 00:54:31 PDT 2017


dtemirbulatov added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:227
+static void propagateIRFlagsWithOp(Value *I, ArrayRef<Value *> VL, Value *OpValue) {
+  if (auto *VecOp = dyn_cast<Instruction>(I)) {
+    auto *Intersection = cast<Instruction>(OpValue);
----------------
dtemirbulatov wrote:
> filcab wrote:
> > Remove indentation levels like you do further in the function:
> > 
> > 
> > ```
> > auto *VecOp = dyn_cast<Instruction>(I);
> > if (!VecOp)
> >   return;
> > // rest of the function
> > ```
> ok, correct
ok


https://reviews.llvm.org/D35292





More information about the llvm-commits mailing list