[PATCH] D35346: [CMake] Enable buildings builtins for Darwin as part of runtimes

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 22:21:22 PDT 2017


phosek created this revision.
Herald added a subscriber: mgorny.

This seems to be working fine in my testing so this error check shouldn't be needed.


Repository:
  rL LLVM

https://reviews.llvm.org/D35346

Files:
  runtimes/CMakeLists.txt


Index: runtimes/CMakeLists.txt
===================================================================
--- runtimes/CMakeLists.txt
+++ runtimes/CMakeLists.txt
@@ -224,14 +224,6 @@
           set(target ${LLVM_DEFAULT_TARGET_TRIPLE})
         endif()
 
-        string(REPLACE "-" ";" builtin_target_list ${target})
-        foreach(item ${builtin_target_list})
-          string(TOLOWER "${item}" item_lower)
-          if(item_lower MATCHES "darwin")
-            message(FATAL_ERROR "LLVM_BUILTIN_TARGETS isn't implemented for Darwin platform!")
-          endif()
-        endforeach()
-
         foreach(variableName ${variableNames})
           if(variableName MATCHES "^BUILTINS_${target}")
             string(REPLACE "BUILTINS_${target}_" "" new_name ${variableName})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35346.106378.patch
Type: text/x-patch
Size: 772 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170713/1e34bfcb/attachment.bin>


More information about the llvm-commits mailing list