[PATCH] D35335: [AMDGPU] fcaninicalize min/max optimization for GFX9+

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:4681
+    if (ST->supportsMinMaxDenormModes() &&
+        isKnownNeverSNan(DAG, Op.getOperand(0)) &&
+        isKnownNeverSNan(DAG, Op.getOperand(1)))
----------------
I believe is KnownNeverSNan is too much here, because it actually returns true if just fp-exceptions disabled. We still must support fmin/fmax correct behavior with signaling nans.


https://reviews.llvm.org/D35335