[PATCH] D35335: [AMDGPU] fcaninicalize min/max optimization for GFX9+
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 12 16:25:58 PDT 2017
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:4680
+ if (ST->supportsMinMaxDenormModes() &&
+ isKnownNeverSNan(DAG, Op.getOperand(0)) &&
----------------
Doesn't this need to check whether deforms are enabled or not
================
Comment at: test/CodeGen/AMDGPU/fcanonicalize-elimination.ll:353
+; GFX9: flat_store_dword v[{{[0-9:]+}}], [[V]]
+; GFX9-NOT: 1.0
define amdgpu_kernel void @test_fold_canonicalize_minnum_value_from_load_f32(float addrspace(1)* %arg) {
----------------
The not check isn't useful here
https://reviews.llvm.org/D35335
More information about the llvm-commits
mailing list