[PATCH] D35282: [Dominators] Split SemiNCA into smaller functions

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar marked 4 inline comments as done.
kuhar added inline comments.


================
Comment at: include/llvm/Support/GenericDomTreeConstruction.h:34
+#define DTB_DEBUG_TYPE "dom-tree-builder"
+#define DTB_DEBUG(Arg) DEBUG_WITH_TYPE(DTB_DEBUG_TYPE, Arg)
+
----------------
davide wrote:
> kuhar wrote:
> > dberlin wrote:
> > > Why doesn't #define DEBUG_TYPE work?
> > The macro can clash with DEBUG_TYPE in a file including it. Is it better change it to DEBUG_TYPE and undef it at the bottom of this header?
> This seems to be symptom of a more general problem, there shouldn't be clashes. Which file is actually defining another `dom-tree-builder` ?
You were absolutely right. MachineCombiner defined the `DEBUG_TYPE` *before* including headers, and that was the root cause.


https://reviews.llvm.org/D35282