ruiu added a comment. The --color-diagnostics option is supported by lld only at the moment, but we could add the option to other linkers, so I think as long as a linker accepts it, we want to pass that flag. https://reviews.llvm.org/D35327