[PATCH] D35236: Refactor gdb index creation

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.cpp:1811
+template <class ELFT> GdbIndexSection *elf::createGdbIndex() {
+  std::vector<InputSection *> V = getDebugInfoSections();
+  std::vector<GdbIndexChunk> Chunks;
----------------
Looks like you can remove `V` as it is used only once.


================
Comment at: ELF/SyntheticSections.h:539
 };
+template <class ELFT> GdbIndexSection *createGdbIndex();
 
----------------
nit: add a blank line before this line.


https://reviews.llvm.org/D35236