[PATCH] D34962: [TargetLowering] Add hook for adding target MMO flags when doing ISel.

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

This LGTM.

The getMMOFlags addition can be a separate patch, right? If so, please separate it.

I'd also really like a comment added to include/llvm/CodeGen/MachineMemOperand.h, around here:

  // Reserved for use by target-specific passes.
  MOTargetFlag1 = 1u << 6,
  MOTargetFlag2 = 1u << 7,
  MOTargetFlag3 = 1u << 8,

reminding us that if we add more flags here we also need to update the MIR printing/parsing code.


https://reviews.llvm.org/D34962