[PATCH] D35292: [SLPVectorizer] Add propagateIRFlagsWithOp() function to propagate IRFlags for specific Operation

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 10:32:32 PDT 2017


RKSimon added a comment.

In https://reviews.llvm.org/D35292#806791, @dtemirbulatov wrote:

> > I don't get what you want to do here, sorry.
> > As I see it, in all the uses of propagateIRFlagsWithOp(X, Y, Z), we have Z == Y[0]. Which will end up being *almost* the same as the propagateIRFlags but with the side-effect that Z will also have those flags.
>
> propagateIRFlagsWithOp only collects flags from Y if Y.Code == Z.Code while propagateIRFlags copies any flag from Y.


Please can you explain that difference from propagateIRFlags in the comment?


https://reviews.llvm.org/D35292





More information about the llvm-commits mailing list