[PATCH] D35001: [LNT] Missing "Produced by" field on Run causes UI to crash

[Leandro Nunes via Phabricator via llvm-commits]

leandron added a comment.

I'll submit a new version including these fixes.



================
Comment at: tests/server/ui/V4Pages.py:143
+
+def check_table_row_content(table, expected_row_content):
+    body_content = get_table_body_content(table)
----------------
kristof.beyls wrote:
> I was confused by the name "check_table_row_content", not sure what this function was doing based on the name.
> After reading the implementation, I guess "check_row_is_in_table" is a better name?
Yes. I'll rename.


================
Comment at: tests/server/ui/V4Pages.py:168
 
+def check_producer_label(client, url, table_header, label):
+    resp = check_code(client, url)
----------------
kristof.beyls wrote:
> Isn't table_header always "Produced by" for check_producer_label?
> If so, wouldn't it be better to make the signature of check_producer_label(client, url, label)?
Makes sense. I'll change.


https://reviews.llvm.org/D35001